naett.c

commit 1a1426e516bbd929bf1253095ae367bf0112fe90
parent 5273897e0ef2b0186df29923dd3e297699d599ca
Author: Henrik Rydgård <hrydgard@gmail.com>
Date:   Mon, 31 Jul 2023 11:21:44 +0200

Address feedback

Diffstat:
M
src/naett_core.c
 | 
4
++--
M
src/naett_linux.c
 | 
4
+---
M
src/naett_win.c
 | 
2
+-

3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/naett_core.c b/src/naett_core.c
@@ -149,12 +149,12 @@ naettOption* naettHeader(const char* name, const char* value) {
     return (naettOption*)option;
 }
 
-naettOption* naettUserAgent(const char* method) {
+naettOption* naettUserAgent(const char* userAgent) {
     naettAlloc(InternalOption, option);
     option->numParams = 1;
     InternalParam* param = &option->params[0];
 
-    param->string = method;
+    param->string = userAgent;
     param->offset = offsetof(RequestOptions, userAgent);
     param->setter = stringSetter;
 
diff --git a/src/naett_linux.c b/src/naett_linux.c
@@ -194,9 +194,7 @@ void naettPlatformMakeRequest(InternalResponse* res) {
 
     struct curl_slist* headerList = NULL;
     char uaBuf[512];
-    if (req->options.userAgent) {
-        snprintf(uaBuf, sizeof(uaBuf), "User-Agent: %s", req->options.userAgent ? req->options.userAgent : NAETT_UA);
-    }
+    snprintf(uaBuf, sizeof(uaBuf), "User-Agent: %s", req->options.userAgent ? req->options.userAgent : NAETT_UA);
     headerList = curl_slist_append(headerList, uaBuf);
 
     KVLink* header = req->options.headers;
diff --git a/src/naett_win.c b/src/naett_win.c
@@ -227,7 +227,7 @@ int naettPlatformInitRequest(InternalRequest* req) {
     req->resource = wcsndup(components.lpszUrlPath, components.dwUrlPathLength + components.dwExtraInfoLength);
     free(url);
 
-    LPWSTR uaBuf = 0;
+    LPWSTR uaBuf = NULL;
     if (req->options.userAgent) {
         uaBuf = winFromUTF8(req->options.userAgent);
     }